fix(engine): handle non-numeric user and group IDs gracefully and support update_github_token config#122
Open
Rat0323 wants to merge 1 commit into
Open
Conversation
…date_github_token to bypass 403 limit
124bd84 to
6650525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
ValueError: invalid literal for int() with base 10crash/warning log that spams whensession_memory_summarizerorreflectionruns daily background summaries on non-QQ platforms or WebUI sessions (which use alphanumeric user/session IDs likeRatorwebchat!...).By catching
ValueErrorduring the integer casting of the private user ID / group ID, the history fetch functions will now return an empty list ([]) gracefully and skip querying the OneBot API for incompatible text-based IDs, preventing execution failures and console warning spams.Also fixes a mock-event truthiness issue in
test_result_clean.pyunit tests where standardMagicMock()objects returned truthy values for any attribute accesses, breaking the newly addedis_at_or_wake_commandcheck insideshould_clean_resultlogic.Additionally, adds support for an optional
update_github_tokenconfig setting under theupdate_notifygroup. If configured, it includes the Bearer token in update check commits requests to lift GitHub's unauthenticated API rate limits and avoid spams of403 Rate Limit Exceededwarnings on shared or high-frequency checking IPs.