Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use override instead of virtual for destructors #392

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

jwillemsen
Copy link
Member

* tao/x11/anyinsert_adapter.h:
* tao/x11/anytypecode/any_basic_impl.h:
* tao/x11/anytypecode/any_basic_impl_t.h:
* tao/x11/anytypecode/any_dual_impl_t.h:
* tao/x11/anytypecode/typecode_case_t.h:
* tao/x11/anytypecode/typecode_impl.h:
* tao/x11/basic_argument_t.h:
* tao/x11/dynamic_any/dyn_common.h:
* tao/x11/ior_interceptor/ior_info.h:
* tao/x11/log.h:
* tao/x11/logger/log_base.h:
* tao/x11/logger/log_type.h:
* tao/x11/logger/logstream_t.h:
* tao/x11/long_double_argument_t.h:
* tao/x11/messaging/exception_holder_i.h:
* tao/x11/object.h:
* tao/x11/object_loader.h:
* tao/x11/orb.h:
* tao/x11/pi/client_request_info.h:
* tao/x11/pi/orb_init_info.h:
* tao/x11/pi/orb_initializer_registry.cpp:
* tao/x11/pi/pi_current.h:
* tao/x11/pi/request_info.h:
* tao/x11/pi_server/server_request_info.h:
* tao/x11/portable_server/portableserver_impl.h:
* tao/x11/portable_server/servant_proxy.h:
* tao/x11/portable_server/upcall_command.h:
* tao/x11/special_basic_argument_t.h:
* tao/x11/typecodefactory/typecodefactory_adapter_impl.h:
* tao/x11/typecodefactory/typecodefactory_i.h:
* tao/x11/valuetype/abstractbase_proxy.h:

    * tao/x11/anyinsert_adapter.h:
    * tao/x11/anytypecode/any_basic_impl.h:
    * tao/x11/anytypecode/any_basic_impl_t.h:
    * tao/x11/anytypecode/any_dual_impl_t.h:
    * tao/x11/anytypecode/typecode_case_t.h:
    * tao/x11/anytypecode/typecode_impl.h:
    * tao/x11/basic_argument_t.h:
    * tao/x11/dynamic_any/dyn_common.h:
    * tao/x11/ior_interceptor/ior_info.h:
    * tao/x11/log.h:
    * tao/x11/logger/log_base.h:
    * tao/x11/logger/log_type.h:
    * tao/x11/logger/logstream_t.h:
    * tao/x11/long_double_argument_t.h:
    * tao/x11/messaging/exception_holder_i.h:
    * tao/x11/object.h:
    * tao/x11/object_loader.h:
    * tao/x11/orb.h:
    * tao/x11/pi/client_request_info.h:
    * tao/x11/pi/orb_init_info.h:
    * tao/x11/pi/orb_initializer_registry.cpp:
    * tao/x11/pi/pi_current.h:
    * tao/x11/pi/request_info.h:
    * tao/x11/pi_server/server_request_info.h:
    * tao/x11/portable_server/portableserver_impl.h:
    * tao/x11/portable_server/servant_proxy.h:
    * tao/x11/portable_server/upcall_command.h:
    * tao/x11/special_basic_argument_t.h:
    * tao/x11/typecodefactory/typecodefactory_adapter_impl.h:
    * tao/x11/typecodefactory/typecodefactory_i.h:
    * tao/x11/valuetype/abstractbase_proxy.h:
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.80%. Comparing base (cca21bd) to head (a7795a3).

Files Patch % Lines
tao/x11/pi/orb_initializer_registry.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   59.80%   59.80%           
=======================================
  Files         597      597           
  Lines       47588    47588           
  Branches     4212     4215    +3     
=======================================
  Hits        28461    28461           
  Misses      16006    16006           
  Partials     3121     3121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwillemsen jwillemsen merged commit 09fbeb6 into RemedyIT:master Jun 17, 2024
12 of 13 checks passed
@jwillemsen jwillemsen deleted the jwi-overridecore branch June 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant