Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derating analysis errors #1279

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

weibullguy
Copy link
Collaborator

Does this PR introduce a breaking change?

  • Yes
  • No

Describe the purpose of this pull request.

To fix IndexErrors and KeyErrors raised during derating analysis.

Describe how this was implemented.

Added error handling to the derating analysis.

Describe any particular area(s) reviewers should focus on.

None

Provide any other pertinent information.

Pull Request Checklist

  • Code Style

    • Code is following code style guidelines.
  • Static Checks

    • Failing static checks are only applicable to code outside the scope of
      this PR.
  • Tests

    • At least one test for all newly created functions/methods?
  • Chores

    • Issue(s) have been raised for problem areas outside the scope of
      this PR. These problem areas have been decorated with an ISSUE: # comment.

* master:
  build: bump sqlalchemy-utils from 0.40.0 to 0.41.0 (#1247)
  build: bump pytest from 7.3.0 to 7.3.1 (#1246)
  build: bump mock from 5.0.1 to 5.0.2 (#1245)
  build: bump xlsxwriter from 3.0.9 to 3.1.0 (#1244)
  build: bump pygments from 2.14.0 to 2.15.0 (#1243)
  build: bump pytest-sugar from 0.9.6 to 0.9.7 (#1242)
  build: bump sqlalchemy from 2.0.8 to 2.0.9 (#1239)
  build: bump mypy from 1.1.1 to 1.2.0 (#1240)
  build: bump pytest from 7.2.2 to 7.3.0 (#1241)
@github-actions github-actions bot added bump: patch Issue or PR documents a bug fix or enhancement requiring a patch version bump. type: fix Issue or PR affects existing functionality. labels May 29, 2023
@weibullguy weibullguy added priority: normal Issue or PR is normal priority. status: inprogress Issue or PR is open, milestoned, and assigned. and removed bump: patch Issue or PR documents a bug fix or enhancement requiring a patch version bump. labels May 29, 2023
Co-authored-by: Sourcery AI <>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 90.41% and project coverage change: -0.08 ⚠️

Comparison is base (83c3db7) 96.88% compared to head (d57e40e) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   96.88%   96.80%   -0.08%     
==========================================
  Files         157      157              
  Lines        5529     5548      +19     
  Branches      491      498       +7     
==========================================
+ Hits         5357     5371      +14     
- Misses        147      150       +3     
- Partials       25       27       +2     
Flag Coverage Δ
3.10 96.80% <90.41%> (-0.08%) ⬇️
3.8 96.79% <90.27%> (-0.08%) ⬇️
3.9 96.80% <90.27%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ramstk/utilities.py 96.29% <ø> (ø)
src/ramstk/__main__.py 50.93% <25.00%> (-0.97%) ⬇️
src/ramstk/analyses/derating/models/capacitor.py 92.00% <60.00%> (-8.00%) ⬇️
src/ramstk/configuration.py 89.83% <92.00%> (ø)
...c/ramstk/analyses/derating/models/semiconductor.py 100.00% <100.00%> (ø)
src/ramstk/analyses/milhdbk217f/models/inductor.py 100.00% <100.00%> (ø)
...dels/dbrecords/programdb_design_electric_record.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* master:
  build: bump pytest-cov from 4.0.0 to 4.1.0 (#1278)
  build: bump pre-commit from 3.3.1 to 3.3.2 (#1275)
  build: bump docformatter from 1.7.0 to 1.7.1 (#1272)
  build: bump requests from 2.28.2 to 2.31.0 (#1276)
  build: bump xlsxwriter from 3.1.0 to 3.1.2 (#1277)
  build: bump sqlalchemy from 2.0.13 to 2.0.15 (#1273)
  build: bump docformatter from 1.6.5 to 1.7.0 (#1271)
  build: bump sphinx from 7.0.0 to 7.0.1 (#1270)
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Issue or PR is normal priority. status: inprogress Issue or PR is open, milestoned, and assigned. type: fix Issue or PR affects existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant