Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CMake, install BLAS::BLAS and LAPACK::LAPACK #840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weslleyspereira
Copy link
Collaborator

Attempt to close #483.

Currently, FindLAPACK in CMake offers two ways to link LAPACK libraries:

  1. use the variable LAPACK_LIBRARIES, an "uncached list of libraries (using full path name) to link against to use LAPACK".
  2. use the target LAPACK::LAPACK, which is a CMake target.

In current version of LAPACK, we install a target ${LAPACKLIB}, where LAPACKLIB is a variable that has to do with the name of the library installed in the system.

This PR changes the installation to LAPACK::LAPACK which agrees with FindLAPACK from CMake. The variable LAPACK_LIBRARIES remains unchanged. I also install BLAS::BLAS instead of the target ${BLASLIB} to conform with FindBLAS from CMake.

Notice that the only thing this PR does is to rename of two CMake variables (3, if we consider LAPACK::TMGLIB).

Comments are welcome!

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0c44dd4) 0.00% compared to head (cd20f88) 0.00%.

❗ Current head cd20f88 differs from pull request most recent head c819999. Consider uploading reports for the commit c819999 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1908     1908           
  Lines      186962   186962           
=======================================
  Misses     186962   186962           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with CMake's imported targets LAPACK::LAPACK
1 participant