Skip to content

Suffixed source fixes - #1434

Merged
ACSimon33 merged 6 commits into
Reference-LAPACK:masterfrom
mohawk2:suffixed-source-fixes
Oct 6, 2026
Merged

ACSimon33 merged 6 commits into
Reference-LAPACK:masterfrom
mohawk2:suffixed-source-fixes

Conversation

@mohawk2

@mohawk2 mohawk2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Description

This constitutes an independent part of (and partial preparation for) #1407, fixing these problems:

  • the Makefiles currently do not clean all their outputs
  • there is no easy self-contained test for GenerateSuffixedSource.cmake

Checklist

  • The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

@mohawk2

mohawk2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

@ACSimon33 I am hoping this PR will be quite an easy change to accept, and would reduce what I call the "overhang" of PR #1407.

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.39%. Comparing base (6de9594) to head (24c676c).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files        6122     6122           
  Lines      487623   487623           
  Branches    23268    23268           
=======================================
  Hits       338408   338408           
  Misses     148781   148781           
  Partials      434      434           
Components Coverage Δ
BLAS 99.13% <ø> (ø)
CBLAS 96.98% <ø> (ø)
LAPACK 82.30% <ø> (ø)
LAPACKE 2.17% <ø> (ø)
TMGLIB 55.69% <ø> (ø)
BLAS testing 88.54% <ø> (ø)
CBLAS testing 89.63% <ø> (ø)
LAPACK testing 82.21% <ø> (ø)
LAPACKE testing ∅ <ø> (∅)
Files with missing lines Coverage Δ
SRC/cgedmdq.f90 78.19% <ø> (ø)
SRC/dgedmdq.f90 77.34% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de9594...24c676c. Read the comment docs.

Comment thread CMAKE/GenerateSuffixedSource.test Outdated
Comment thread CMAKE/GenerateSuffixedSource.cmake Outdated
@mohawk2
mohawk2 force-pushed the suffixed-source-fixes branch from adf9561 to cf38849 Compare October 5, 2026 23:48
@mohawk2
mohawk2 requested a review from ACSimon33 October 5, 2026 23:49
@mohawk2
mohawk2 force-pushed the suffixed-source-fixes branch from cf38849 to 24c676c Compare October 5, 2026 23:51
@ACSimon33
ACSimon33 merged commit 1281d14 into Reference-LAPACK:master Oct 6, 2026
47 checks passed
@mohawk2
mohawk2 deleted the suffixed-source-fixes branch October 7, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants