Repository navigation
Suffixed source fixes - #1434
Merged
Merged
Conversation
Contributor
Author
|
@ACSimon33 I am hoping this PR will be quite an easy change to accept, and would reduce what I call the "overhang" of PR #1407. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1434 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 6122 6122
Lines 487623 487623
Branches 23268 23268
=======================================
Hits 338408 338408
Misses 148781 148781
Partials 434 434
Continue to review full report in Codecov by Harness.
|
ACSimon33
requested changes
Oct 3, 2026
mohawk2
force-pushed
the
suffixed-source-fixes
branch
from
October 5, 2026 23:48
adf9561 to
cf38849
Compare
Co-authored-by: Simon Lukas Märtens <git@slmaertens.dev>
mohawk2
force-pushed
the
suffixed-source-fixes
branch
from
October 5, 2026 23:51
cf38849 to
24c676c
Compare
ACSimon33
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This constitutes an independent part of (and partial preparation for) #1407, fixing these problems:
Makefiles currently do not clean all their outputsGenerateSuffixedSource.cmakeChecklist