-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for the master (4.4) branch - 2nd batch #804
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why some of the changes are just switching if statements from if condition {} else {} to the conditional op ? . guess it does look cleaner
961e416
to
2b5c37e
Compare
7b8a341
to
f3cd889
Compare
cc3a8e6
to
5c98f88
Compare
I prefer this ternary operator. Could it be set as good pattern from now on here? |
3544cc7
to
d5f587c
Compare
78f68ab
to
90274d0
Compare
Remove vbl child from `ColorPicker` Remove vbr child from `ColorPicker`, prefer `real_vbox` (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 18d0193) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 9db102a) Co-authored-by: Mounir Tohami <[email protected]>
It seems to be vestigial inherited from the ColorPicker refactor (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 86eb475) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit e3650df) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 59101cb) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit e3ac6fb) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 3265e08) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 7a16a43) Co-authored-by: Mounir Tohami <[email protected]>
…ight. (cherry picked from commit blazium-engine/blazium@f7c6762) (cherry picked from commit 72ade00) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@ca09c1d) (cherry picked from commit ad35df2) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit d09a29e) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit 40d36f6) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit blazium-engine/blazium@5ca9caa) (cherry picked from commit f6edeb0) Co-authored-by: Mounir Tohami <[email protected]>
(cherry picked from commit 78ae5ca)
(cherry picked from commit 1ea7e4e)
(cherry picked from commit 7e8c731)
Correct version.py to act as a dev version (cherry picked from commit f615cbb)
(cherry picked from commit 6c1a415)
(cherry picked from commit 0f52c97)
(cherry picked from commit 0aad787)
(cherry picked from commit 0660491)
(cherry picked from commit 1a324d6)
(cherry picked from commit 9b91d9a)
(cherry picked from commit 621c8c8) Co-authored-by: Spartan322 <[email protected]>
(cherry picked from commit 9c21b01)
(cherry picked from commit 3158d1b)
(cherry picked from commit 97a044f)
(cherry picked from commit 95c90a9)
2b34139
to
00c9c90
Compare
(cherry picked from commit 0f7b5f9)
Closes #697
Closes #838
Closes #840
Fixes #712
Fixes #857
Related:
Websocket dropping data violates TCP reliability and congestion control godotengine/godot#70738(see Merge commit godotengine/godot@cb411fa #855)Focus "outline" for sliders moves with scrolling godotengine/godot#97825(see Merge commit godotengine/godot@cb411fa #855)ColorPicker
's sample left half side changes the color to black when old color is not displayed. godotengine/godot#88073Includes:
ScrollBar
grabber mouse ignores scroll margin #777ColorPicker
RGB+RAW modes to have overbright values #778ColorPicker
Containers #779ColorPicker
HSV Rectangle/Wheel draw #781ColorModeOKHSL.get_shape_override
#782ColorPicker
color mode slider colors #783ColorPicker
color picking #784ColorMode
jank sliders and spinbox #794ColorPicker
inactive left side sample reset #795ColorPicker
overbright indicator position #803CanvasItemEditor
redraw on key echo #805CanvasItemEditor
duplicate hovering behavior #806CanvasItemEditor
snap lines drawing and input #807VERSION_FULL_CONFIG
excess dot on 0 #848versions.json
check with Github release check #851gh_ratelimit
's creation path being outside Redot #852Node._unhandled_picking_input
to refer to InputEvent #865using Redot;
tousing Godot;
in docs #872Removed:
EditorSpinSlider
grabber doesn't follow parent when scrolling #776:EditorSpinSlider
grabberTextureRect
doesn't follow parent when scrolling. godotengine/godot#97946: see Merge commit godotengine/godot@cb411fa #855