[CNV-75960] Add STP for Multi-Arch Boot Image Import and DataSource Lifecycle#22
[CNV-75960] Add STP for Multi-Arch Boot Image Import and DataSource Lifecycle#22geetikakay wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new Software Test Plan "Multi-Architecture Boot Image Import and DataSource Lifecycle - Quality Engineering Plan" at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
geetikakay
force-pushed
the
infra_stp_multiarch
branch
5 times, most recently
from
ca56a76 to
2665393
Compare
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
2665393 to
767aeae
Compare
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@stps/sig-infra/multiarch-automation.md`:
- Line 225: Update the table row under the "Untestable Aspects" column that
reads "Very large scale environment (50+ OS images across multiple
architectures)" to hyphenate the compound adjective: change it to "Very
large-scale environment (50+ OS images across multiple architectures)"; ensure
you only modify that phrase in the multiarch-automation.md table row and keep
the rest of the cell content unchanged.
- Line 202: Fix the typo in the checklist item containing
"enableMultiArchBootImageImport": change the misspelled word "releas" to
"release" so the line reads "[ ] enableMultiArchBootImageImport feature is
**available in target release**"; update the text wherever that exact checkbox
string appears in multiarch-automation.md (search for
"enableMultiArchBootImageImport") to ensure consistency.
- Line 68: The table row has 5 cells but the header defines 4, breaking markdown
rendering; update the row in multiarch-automation.md so it has exactly four
pipe-separated cells by removing the extra cell separator — either merge the two
rightmost cells into one (so the long API Extensions content remains as a single
cell) or escape any literal '|' characters inside the cell content (use |
or wrap the inner content to avoid creating extra columns). Ensure the cell
containing the API Extensions text (referencing HCO: status.nodeInfo,
status.dataImportCronTemplates; SSP: enableMultipleArchitectures, cluster
fields; CDI: platform.architecture, arch-specific DataSource naming) is kept
intact as a single table cell.
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
767aeae to
8e0ca44
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@stps/sig-infra/multiarch-automation.md`:
- Line 59: Resolve the contradiction between the "Non-Functional Requirements
(NFRs)" summary row and the "Usability Testing" entry by choosing one scope
decision and updating both places: either (A) keep usability in-scope—change the
NFRs row text to exclude "Usability" or reword to explicitly state which NFRs
are out of scope and ensure "Usability Testing" stays marked "Y" with its
validation tasks (reference the table row titled "Non-Functional Requirements
(NFRs)" and the section/header "Usability Testing"), or (B) keep usability
out-of-scope—set "Usability Testing" to "N" and remove the naming-convention
validation tasks under that section; make the two entries consistent and update
any related checklist or validation steps to match.
🧹 Nitpick comments (3)
stps/sig-infra/multiarch-automation.md (3)
5-17: Consider adding VEP issue field to metadata table.The PR description mentions a VEP issue field but it's not present in the metadata table. While the Enhancement field links to the VEP document, consider adding an explicit "VEP Issue" row for consistency with other STPs in the repository.
📋 Suggested addition to metadata table
| **Enhancement(s)** | [dic-on-heterogeneous-cluster](https://github.com/kubevirt/enhancements/blob/main/veps/sig-storage/dic-on-heterogeneous-cluster/dic-on-heterogeneous-cluster.md) | +| **VEP Issue** | TBD or N/A | | **Feature in Jira** | [VIRTSTRAT-494](https://issues.redhat.com/browse/VIRTSTRAT-494) |
177-177: Clarify compute resource requirements for multi-arch testing.Marking "Compute Resources" as "N/A" with "No special compute requirements" may be misleading for a multi-arch test plan that explicitly requires both amd64 and arm64 node architectures (line 174). Consider clarifying that while there are no special CPU/memory quantity requirements, the architecture diversity is itself a compute requirement.
📝 Suggested clarification
-| **Compute Resources** | N/A | No special compute requirements | +| **Compute Resources** | Mixed architecture nodes required | No special CPU/memory quantities beyond standard worker nodes. Architecture diversity (amd64 + arm64) is mandatory per cluster topology. |
244-261: Restructure traceability matrix to link test cases to requirements.The current table uses "Requirement ID" for test case identifiers (TC-01, etc.), but does not trace these test cases back to actual requirements from Jira (e.g., VIRTSTRAT-494 or sub-requirements/user stories). This reduces traceability and makes it difficult to verify that all requirements are covered.
Consider restructuring to either:
- Add a separate "Requirement ID" column that references Jira issues/epics, or
- Rename "Requirement ID" to "Test Case ID" and add requirement traceability in the description
🔗 Example restructured table with requirement traceability
Option 1: Add requirement column (preferred for full traceability):
| Requirement ID | Test Case ID | Test Scenario Summary | Tier | Priority | Known Issues | | :------------- | :----------- | :-------------------- | :--- | :------- | :----------- | | VIRTSTRAT-494 | TC-01 | Golden images on multi-arch cluster | Tier 1 | P0 | | | VIRTSTRAT-494 | TC-02 | Images added post-deployment | Tier 2 | P1 | | ...Option 2: Rename column to clarify:
| Test Case ID | Test Scenario Summary | Tier | Priority | Known Issues | | :----------- | :-------------------- | :--- | :------- | :----------- | | TC-01 (VIRTSTRAT-494) | Golden images on multi-arch cluster | Tier 1 | P0 | |
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
8e0ca44 to
9f513ef
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@stps/sig-infra/multiarch-automation.md`:
- Line 210: The exit criteria line currently reads "All P0, P1 test scenarios
executed and passing (TC-01, TC-03, TC-06, TC-07, TC-11)" but only lists a
subset; either expand the parenthetical to include every P0 and P1 test case or
change the wording to accurately reflect the list (e.g., "Key P0/P1 scenarios
executed and passing (TC-01, TC-03, TC-06, TC-07, TC-11)"). Update the checklist
text (the line starting with "[ ] All P0, P1 test scenarios executed and
passing") to use one of these two fixes and ensure the phrasing matches the
scope of the listed TC identifiers.
- Around line 170-181: The "Required Operators" row in the environment table
leaves the "Specification Examples" cell empty; update the table so no cells are
blank by adding concrete examples such as operator names and versions (e.g.,
"SSP v1.x, CDI v1.x, HCO v1.x" or the specific operator package names + minimal
version constraints) in the "Specification Examples" column for the "Required
Operators" row to match the rule that "N/A" or explicit values must be present.
RoniKishner
left a comment
RoniKishner
left a comment
There was a problem hiding this comment.
Really Good Job on this STP.
can you add to the PR description a link to https://github.com/geetikakay/openshift-virtualization-tests-design-docs/blob/infra_stp_multiarch/stps/sig-infra/multiarch-automation.md
This will help review the STP in a more human eye way.
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
9f513ef to
7612d1e
Compare
|
/lgtm |
There was a problem hiding this comment.
Removing nodes isn't a simple task, i'm not sure if we can do it in openshift-virtualization-tests, but if we can, I think it fits the tier 3 section.
Lets Check with a product manager if we should put it as a priority 0 ?
There was a problem hiding this comment.
you are right . This will be a destructive task and i am unsure if we should really put this in . I will ask maintainers
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
7612d1e to
db8068c
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stps/sig-infra/multiarch-automation.md (1)
182-182: Consider adding operator version specifications.The "Specification Examples" column contains "N/A" but typically would list operator versions or package names (e.g., "SSP operator v4.21+, CDI operator v1.60+, HCO v4.21+"). While "N/A" satisfies the "no empty cells" rule, providing actual version constraints would improve clarity.
💡 Optional enhancement
-| **Required Operators** | SSP, CDI, HCO | N/A | +| **Required Operators** | SSP, CDI, HCO | SSP operator v4.21+, CDI operator v1.60+, HCO v4.21+ (versions supporting enableMultiArchBootImageImport) |
…ifecycle STP for enableMultiArchBootImageImport feature testing on heterogeneous clusters. Covers DataSource lifecycle, architecture labeling, duplicate prevention, and cleanup validation. Related: VIRTSTRAT-494 Parent STP: RedHatQE#12 Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
geetikakay
force-pushed
the
infra_stp_multiarch
branch
from
db8068c to
6fd11d3
Compare
6 participants
STP for enableMultiArchBootImageImport feature testing on heterogeneous clusters. Covers DataSource lifecycle, architecture labeling, duplicate prevention, and cleanup validation.
Related: VIRTSTRAT-494
Parent STP: #12
STP Metadata
VEP issue:
What this PR does
Special notes for your reviewer
Summary by CodeRabbit