Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adr-001 cli implementation #347

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: adr-001 cli implementation #347

wants to merge 5 commits into from

Conversation

gvauter
Copy link
Member

@gvauter gvauter commented Sep 17, 2024

Description

Adds ADR for proposed Click CLI and config file implementation.

@gvauter gvauter added enhancement New feature or request breaking_change Backward incompatible changes proposal Issue with a design proposal labels Sep 17, 2024
@gvauter gvauter changed the title docs: ADR-001 CLI implementation docs: adr-001 cli implementation Sep 18, 2024
@gvauter gvauter marked this pull request as ready for review September 18, 2024 17:03
jpower432
jpower432 reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this makes sense to me. A couple questions around the config.

docs/architecture/decisions/implement-cli-framework_001.md Outdated Show resolved Hide resolved
docs/architecture/decisions/implement-cli-framework_001.md Outdated Show resolved Hide resolved
docs/architecture/decisions/implement-cli-framework_001.md Outdated Show resolved Hide resolved
jpower432
jpower432 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

@d10n d10n Awaiting requested review from d10n

@beatrizmcouto beatrizmcouto Awaiting requested review from beatrizmcouto

Assignees
No one assigned
Labels
breaking_change Backward incompatible changes enhancement New feature or request proposal Issue with a design proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvauter @jpower432