Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates logger and entrypoint script to log errors written to st… #19

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jpower432
Copy link
Member

…derr

Description

Fix bug on main where errors and trestle logs are not logged through the entrypoint script configuration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tested manually with the below steps:

  1. Build the image
    podman build -f Dockerfile -t localhost:5000/trestlebot:latest
  2. Set the environment file up with the following content
GITHUB_OUTPUT=
INPUT_SKIP_ITEMS=
INPUT_CHECK_ONLY=true
INPUT_SKIP_ASSEMBLE=false
INPUT_SKIP_REGENERATE=false
INPUT_REPOSITORY=.
INPUT_BRANCH=test
INPUT_MARKDOWN_PATH=markdown/profiles
INPUT_OSCAL_MODEL=profile
INPUT_SSP_INDEX_PATH=
INPUT_COMMIT_MESSAGE=
INPUT_COMMIT_USER_NAME=me
[email protected]
INPUT_FILE_PATTERN=*.md,*.json
INPUT_COMMIT_AUTHOR_NAME=
INPUT_COMMIT_AUTHOR_EMAIL=
INPUT_TARGET_BRANCH="test"
GITHUB_ACTIONS=true
  1. Run with entrypoint script
    podman run --entrypoint /entrypoint.sh --env-file=envfile -v trestle-workspace/:/data -w /data localhost:5000/trestlebot:latest

Outcome: Trestle error should be logged. To reproduce, ensure that the workspace is dirty to produce a failure with check_only

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 merged commit 7dfa741 into RedHatProductSecurity:main Jul 11, 2023
6 checks passed
@jpower432 jpower432 deleted the bug/logging-stderr branch August 3, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant