Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail container build if zap could not be downloaded #282

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sfowl
Copy link
Collaborator

@sfowl sfowl commented Jan 21, 2025

This will cause the container build to fail, however it's currently broken anyway because the v2.14.0 version of zap has been removed upstream. The container build should have failed earlier but did not.

Once the zap retrieval issue is fixed, the build should go back to green.

@sfowl sfowl self-assigned this Jan 21, 2025
@sfowl sfowl requested a review from a team as a code owner January 21, 2025 03:53
Copy link
Collaborator

@jeremychoi jeremychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfowl sfowl merged commit 4f2d766 into development Jan 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants