Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove planned deprecations for bumping 3.4.0 #4134

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Jun 28, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

  • remove code that was deprecated for at least 1 year

@xiangce xiangce requested a review from JoySnow June 28, 2024 02:57
@xiangce xiangce merged commit a81cb3d into master Jul 2, 2024
9 of 11 checks passed
@xiangce xiangce deleted the n_3.4.0 branch July 2, 2024 09:45
xiangce added a commit that referenced this pull request Jul 2, 2024
- the parsers were removed in #4134

Signed-off-by: Xiangce Liu <[email protected]>
@xiangce
Copy link
Contributor Author

xiangce commented Jul 2, 2024

Oops, docstring-making error was missed to check. will fix them in a new PR #4137

xiangce added a commit that referenced this pull request Jul 3, 2024
- the parsers were removed in #4134, but doc-entries was forgotten to remove

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants