馃敟 Remove non-root directory logic #3234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insights Client must be run as root. The logic determining log and lib directories for a non-root user is never used. Signed-off-by: 艩t臎p谩n Tomsa <[email protected]>
subpop
approved these changes
Sep 24, 2021
gravitypriest
approved these changes
Sep 24, 2021
|
Looks good, but keep in mind we do want to be able to run as non-root someday. Until then though, 馃憤 |
|
If non-root ever turns up as a requirement again, we'll need to take a new, holistic approach to it anyway, so I'm fine dropping unused code in the interim. |
bfahr
added
the
client
|
Hi, @Glutexo! This issue has been reported and is being analyzed here: RHCLOUD-17392. |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
The Insights Client can only be run as root. There is a condition that prevents it from running for non-root users. The logic determining log and lib directories for a non-root user is never used.