Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging and CLI update #161

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Minor logging and CLI update #161

merged 1 commit into from
Nov 9, 2023

Conversation

sdatko
Copy link
Member

@sdatko sdatko commented Nov 9, 2023

This commit adds a logging of files written by generator module. Also minor change of parser options names was done for clarity. Related modification of browser module was also performed.

cescgina
cescgina previously approved these changes Nov 9, 2023
Copy link
Contributor

@cescgina cescgina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, but tests are failing

This commit adds a logging of files written by generator module.
Also minor change of parser options names was done for clarity.
Related modification of browser module was also performed.
@sdatko
Copy link
Member Author

sdatko commented Nov 9, 2023

changes lgtm, but tests are failing

Sorry, I launched tox yesterday evening, but I forgot it told me to fix tests... ^^
Corrected now 👍

@sdatko sdatko requested a review from cescgina November 9, 2023 11:34
@sdatko sdatko merged commit 3d9fbd8 into RedHatCRE:main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants