Skip to content

Conversation

@figengungor
Copy link
Contributor

No description provided.

@Klazyo
Copy link

Klazyo commented Mar 18, 2021

Does it work with null safe i am not used to Github .
its the only package left for to migrate is it safe to migrate without changing this package to null safe

@uttufy
Copy link

uttufy commented Mar 22, 2021

Does it work with null safe i am not used to Github .
its the only package left for to migrate is it safe to migrate without changing this package to null safe

Nope you have to use null safety package

in you pubspec.yaml use it like this :

  flutter_datetime_picker:
    git:
      url: https://github.com/figengungor/flutter_datetime_picker.git

@Klazyo
Copy link

Klazyo commented Mar 23, 2021

Does it work with null safe i am not used to Github .
its the only package left for to migrate is it safe to migrate without changing this package to null safe

Nope you have to use null safety package

in you pubspec.yaml use it like this :

  flutter_datetime_picker:
    git:
      url: https://github.com/figengungor/flutter_datetime_picker.git

Thank you sir

@kalmigs
Copy link

kalmigs commented Mar 25, 2021

When I try to "Cancel" or press outside the Date/Time picker bottom sheet it will cause an exception error.
I think "?" should be added to return types so it will not cause the said error:

// original code from flutter_datetime_picker.dart
static Future<DateTime> showDatePicker(
static Future<DateTime> showTimePicker(

// with changes
static Future<DateTime?> showDatePicker(
static Future<DateTime?> showTimePicker(

@figengungor
Copy link
Contributor Author

Thanks @kalmigs. Fixed it.

@Realank Realank merged commit df4ed6f into Realank:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants