-
Notifications
You must be signed in to change notification settings - Fork 49
fix: Route Description table for Users contract #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Route Description table for Users contract #232
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughThe documentation for user-related API routes has been updated. The summary table now includes two new endpoints: Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
users/README.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
users/README.md
[grammar] ~43-~43: When ‘logged-in’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...elf) | Returns the logged in user's details | | [GET /user...
(LOGGED_IN_HYPHEN)
[grammar] ~53-~53: This is normally spelled as one word.
Context: ...ch-usersuserid) | Allows super users to approve profile diff | | [...
(SUPER_COMPOUNDS)
🔇 Additional comments (2)
users/README.md (2)
49-49
: Verify and correct anchor for deprecated PATCH/users/self
The table link uses[#patch-usersself-to-be-deprecated]
, but given the heading## PATCH /users/self(To Be Deprecated)
, GitHub’s slug might actually bepatch-users-self-to-be-deprecated
. Please confirm the generated anchor and update the link to match exactly, preventing broken navigation.
52-52
: Ensure anchor for PUT/users/:userId/intro
matches heading slug
The link currently points to#put-usersuseridintro
, but the heading## PUT /users/:userId/intro
will likely generate a slug likeput-users-userid-intro
. Please verify the correct anchor and adjust the link to avoid a 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider creating issue ticket before raising PR
| [PATCH /users](#patch-users) | Archive users if not in discord | | ||
| [PUT /users/:userId/intro](#put-usersuseridintro) | Create a User Intro in DB if not present | | ||
| [PATCH /users/:userId](#patch-usersuserid) | Allows super users to approve profile diffs | | ||
| [PATCH /users/:userId](#patch-usersuserid) |Allows authenticated users to update profile data| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PATCH /users/:userId is listed twice—should we clarify roles or merge into one row with both use cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is used for 2 things so added it twice , adding both in the same row will increase table width that's why i did not prefer that
|
Date: 01/05/2025
Developer Name: Suvidh Kaushik
Issue Ticket Number
N/A
Description
PUT /users/:userId/intro
andPATCH /users/:userId
which has contracts but were not in the tableDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1