Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 - [WIP] #1179

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

V6 - [WIP] #1179

wants to merge 40 commits into from

Conversation

danielbarion
Copy link
Member

@danielbarion danielbarion commented Mar 14, 2024

  • cleanup of the deprecated options of the Tooltip
  • explore new bundler options (bun.sh?)
  • Rollup upgraded v2 -> v4

Note: we need to consider the custom rollup plugin we did to inject the CSS into the build file (/rollup-plugins/replace-before-save-file.js)

  • check global average browser version and reduce the range on the build that includes polyfills ✅
  • we have different ways to use the tooltip. Check code splitting to reduce the loaded code related to the way the project wants to use react-tooltip
  • improve tooltip performance - how to benchmark it to compare with v5?
  • improve internal state handling (internal state should be updated in the least render cycles possible)
  • review all useMemo()/useCallback()/useEffect() dependencies (the react-hooks/exhaustive-deps rule should only be ignore if strictly necessary, i.e. an specific dependency breaks functionality)
  • break down large effects and functions into more concise (and properly named) functions
  • review docs to make sure it's up to date with V6 changes after PR gets ready to be reviewed
  • write the tests to cover the library code and his utils

@danielbarion danielbarion added the V6 It might get fixed/merged before, but most likely only on V6's release. label Mar 14, 2024
@danielbarion danielbarion changed the title V6 V6 - [WIP] Mar 14, 2024
@danielbarion danielbarion mentioned this pull request Mar 14, 2024
Closed
@gabrieljablonski gabrieljablonski marked this pull request as draft March 14, 2024 18:59
@danielbarion
Copy link
Member Author

danielbarion commented Mar 20, 2024

  • Bun is amazing but unfortunately not an option at the moment because of:

image

Also, note added:

Note: we need to consider the custom rollup plugin we did to inject the CSS into the build file (/rollup-plugins/replace-before-save-file.js)

Copy link

coderabbitai bot commented May 8, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented May 8, 2024

Beta version released with the last commit 🚀

or

npm install [email protected]

Copy link

github-actions bot commented May 9, 2024

Beta version released with the last commit 🚀

or

npm install [email protected]

Copy link

Beta version released with the last commit 🚀

or

npm install [email protected]

@danielbarion
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V6 It might get fixed/merged before, but most likely only on V6's release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants