fix: clear FingerprintResolutionLookupMaps before patching
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if we abort the patching process after merging integrations, we need to restart the app to start another patching process. This PR aims to allow clearing the maps from previous patching session so that new session can be started at any time.
|
Alternatively the patcher can clear the maps in the main patch routine. Then the clear method does not need to be exposed and manager won't need any changes. |
|
Instead: Replace that line with clearFingerprintResolutionLookupMaps() That'll fix the issue |
|
Yes. Since the maps needs to be cleared just for patching process for now, this is a good solution. |
TheAabedKhan
changed the title
FingerprintResolutionLookupMaps before patchingFingerprintResolutionLookupMaps before patching
2 tasks
oSumAtrIX
reviewed
Aug 3, 2023
oSumAtrIX
reviewed
Aug 3, 2023
oSumAtrIX
approved these changes
Aug 3, 2023
|
Thank you for contributing to ReVanced. Join us on Discord if you want to receive a contributor role. |
revanced-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
## [12.1.1-dev.1](v12.1.0...v12.1.1-dev.1) (2023-08-03) ### Bug Fixes * clear method lookup maps before initializing them ([#210](#210)) ([746544f](746544f))
revanced-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
## [12.1.1](v12.1.0...v12.1.1) (2023-08-03) ### Bug Fixes * clear method lookup maps before initializing them ([#210](#210)) ([746544f](746544f))
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we abort the patching process after merging integrations, we need to restart the app to start another patching process.
This PR aims to clear the maps from previous patching session so that new session can be started at any time.