Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Follow language update immediately #1944

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

snehithssv
Copy link

fixes : #1731

@oSumAtrIX oSumAtrIX requested a review from Ushie June 11, 2024 10:53
@TheAabedKhan
Copy link
Member

Can you provide a screen recording of updating the language before and after the commit? Your commit is not fixing the issue on my end.

@snehithssv
Copy link
Author

@TheAabedKhan
Copy link
Member

After the commit a56bdac, the issue is fixed.
Thank you.

@TheAabedKhan TheAabedKhan linked an issue Jun 14, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥞 Approved, thanks!

Compiled using Flutter 3.23.0-0.1.pre (Beta) and tested on physical devices running Android 14 (Samsung One UI 6.1 - 1st May)

@validcube validcube merged commit c13827e into ReVanced:dev Jun 15, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
# [1.21.0-dev.4](v1.21.0-dev.3...v1.21.0-dev.4) (2024-06-24)

### Bug Fixes

* Cache external API calls  ([#1911](#1911)) ([2c3e2e6](2c3e2e6))
* Follow language update immediately ([#1944](#1944)) ([c13827e](c13827e))
* SecurityException when patching application ([#1856](#1856)) ([e0a6de2](e0a6de2))
* Update dialog shows dev version & loading gets stuck in certain circumstances ([#1792](#1792)) ([fc52560](fc52560))

### Features

* Add ability to set `null` in patch options ([#1947](#1947)) ([5c68d51](5c68d51))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Old language remains in settings tab after switching language
5 participants