Skip to content

Conversation

@ben-schwen
Copy link
Member

Closes #7366

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (1685a3b) to head (048fabb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7370   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          85       85           
  Lines       16610    16618    +8     
=======================================
+ Hits        16466    16474    +8     
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

  • HEAD=fread_quote_sep slower P<0.001 for memrecycle regression fixed in #5463
  • HEAD=fread_quote_sep slower P<0.001 for isoweek improved in #7144
    Comparison Plot

Generated via commit 048fabb

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 1 seconds
Installing different package versions 44 seconds
Running and plotting the test cases 2 minutes and 39 seconds

Copy link
Contributor

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a relatively complicated special case, but I wasn't able to simplify it.

@aitap aitap merged commit df7fa80 into master Nov 3, 2025
13 checks passed
@aitap aitap deleted the fread_quote_sep branch November 3, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fread doesn't manage to read without additional pointers

4 participants