Skip to content

Conversation

badasahog
Copy link
Contributor

In many other places in the code, if is spelled iff. I didn't fix the others to avoid creating conflicts.

Also, I've updated type case to snake case. The codebase is mostly snake case, so that's what I think we should go with. If you agree, I will do so more comprehensively.

@badasahog badasahog requested a review from aitap as a code owner September 17, 2025 11:17
@badasahog badasahog requested review from MichaelChirico and removed request for aitap September 17, 2025 11:17
@aitap
Copy link
Contributor

aitap commented Sep 17, 2025 via email

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.10%. Comparing base (59692e7) to head (017cecd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7325   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          84       84           
  Lines       16128    16128           
=======================================
  Hits        15983    15983           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Sep 17, 2025

  • HEAD=fixSpelling slower P<0.001 for isoweek improved in #7144
    Comparison Plot

Generated via commit d38996b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 52 seconds
Installing different package versions 43 seconds
Running and plotting the test cases 2 minutes and 43 seconds

@badasahog
Copy link
Contributor Author

@aitap understood. reverting.

@badasahog badasahog changed the title switch to snake case + minor spelling correction switch to snake case Sep 17, 2025
@badasahog badasahog requested a review from aitap September 29, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants