Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding an atime test case for gshift as gforce optimized shift #5205 #6295

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

adding an atime test case for gshift as gforce optimized shift #5205 #6295

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0013772
adding an atime test case for gshift as gforce optimized shift #5205
DorisAmoakohene Jul 17, 2024
25e276f
Fixed some tense error in comments
DorisAmoakohene Jul 29, 2024
93396ca
Fixed typo
DorisAmoakohene Jul 30, 2024
2f4f570
Resolved conflicts between adding-a-test-for-regression-for-5205 and …
DorisAmoakohene Jul 30, 2024
bb10ce8
remove >> and == from script
DorisAmoakohene Jul 31, 2024
c899b9c
added NULL
DorisAmoakohene Jul 31, 2024
1f8dbbb
Towards resolving merge conflicts
Anirban166 Sep 13, 2024
6e79980
Merge branch 'master' into adding-a-test-for-regression-for-5205
Anirban166 Sep 13, 2024
1ed4d1a
Formatting
Anirban166 Sep 13, 2024
f394d91
Correct comment based on fix status
Anirban166 Sep 13, 2024
3224e7a
Try the last one in PR's range of commits (else simplify comment to u…
Anirban166 Sep 13, 2024
7a25d4f
Slow/Fast (Improvement case) over Regression/Fixed
Anirban166 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,20 @@ test.list <- atime::atime_test_list(
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801)
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)

# Issue reported in: https://github.com/Rdatatable/data.table/issues/1534
# To be fixed in: https://github.com/Rdatatable/data.table/pull/5205
"DT shift improved in #5205" = atime::atime_test(
N = 10^seq(1, 7),
setup = {
DT = data.table(x = sample(N), y = sample(1e2, N, TRUE))
},
expr = {
data.table:::`[.data.table`(DT,, shift(x, 1, type = "lag"), y)
},
Regression = "7f0ce147eef1dd5cd5ff05dffc3c72f472bcde51", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/58135017a985f3cc2c6f0d091c4effaec4442f56) in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the issue
Fixed = "a6abac319446ae7dde8bc4501fae40eeb5cc228c") # Commit before the last commit in the PR (https://github.com/Rdatatable/data.table/pull/5205/commits) that fixes the regression
)

# Issue reported in: https://github.com/Rdatatable/data.table/issues/4200
# To be fixed in: https://github.com/Rdatatable/data.table/pull/4558
"DT[by] fixed in #4558" = atime::atime_test(
Expand Down Expand Up @@ -156,5 +170,4 @@ test.list <- atime::atime_test_list(
Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue

NULL)
tdhock marked this conversation as resolved.
Show resolved Hide resolved
# nolint end: undesirable_operator_linter.
Loading