Fix tbb-compat linking after rename #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if it's because of clang or windows arm64, but
rstan
models compiled against the current githubRcppParallel
fail at runtime with an error thattbb-compat.dll
is not found - even though the DLL has been renamed totbb.dll
before being linked.I believe this is because
R CMD SHLIB
generates a.def
file when linking with the name of the DLL. Explicitly setting the output name totbb.dll
when callingR CMD SHLIB
resolves the later runtime errors for me