Refine when we skip running all tests #1434
Open
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enchufa2
reviewed
Dec 31, 2025
Comment on lines
+6
to
+7
| if (Sys.getenv("OMP_THREAD_LIMIT", unset="") != "" && # it is set | ||
| Sys.getenv("OMP_THREAD_LIMIT") == "2") { # value is two |
Member
There was a problem hiding this comment.
This could be just
if (Sys.getenv("OMP_THREAD_LIMIT", unset="") == "2")or am I missing something?
Member
Author
There was a problem hiding this comment.
Hah! That is what I started from and then, somehow, I stared at it long enough to convince myself that what I committed was better. And of course I no longer see why ... Will ponder some more and likely revert.
Enchufa2
approved these changes
Dec 31, 2025
Member
Enchufa2
left a comment
Enchufa2
left a comment
There was a problem hiding this comment.
Small comment. Otherwise, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1433
This PR adds an additional check to the testrunner. The key question is whether to run 'all tests' (actully 'all' and 'verbose') or just a subset. We prefer released version to only run a subset (as e.g. total test runtime is monitored). So far we made the decision based on release versions such as '1.1.0' (having three components) version development snapshot such as 1.1.0.13' (have four, or more). We have been operating in a way where only the latter gets all tests.
So here we propose to addtionally check for an environment variable that may be a 'tell' for a situation where we rather not run tests, so we now consider this too.
Checklist
R CMD checkstill passes all tests