adapt to tibble from REDCapR #61
Conversation
There was a problem hiding this comment.
some comments to help @RaymondBalise & @gabrielodom evaluate this PR better.
| c(1, 2, 3, 4, 5), | ||
| label = "Study ID", | ||
| class = c("labelled", "numeric") | ||
| ), |
There was a problem hiding this comment.
I'm not sure why the new version of REDCapR produces this change. But I haven't really studied what tidyREDCap does with the labelled class.
There was a problem hiding this comment.
labelled needs to be the last argument in the class list. So we need a unit test to make sure that all is still good. See the fix_class_bug() function in make_instrument_auto.R. It is a horrible kludge. We need to look at the labeling function that REDCapTidieR is using to see if things could be simpler.
| @@ -65,7 +70,7 @@ target <- structure( | |||
| "character" | |||
| )) | |||
| ), | |||
| row.names = c(NA, -5L), class = "data.frame" | |||
| row.names = c(NA, -5L), class = c("tbl_df", "tbl", "data.frame") | |||
There was a problem hiding this comment.
adapt to the tibble that REDCapR returns.
There was a problem hiding this comment.
Need to double check the unit test still behaves but it makes good sense.
| @@ -65,7 +70,7 @@ target <- structure( | |||
| "character" | |||
| )) | |||
| ), | |||
| row.names = c(NA, -5L), class = "data.frame" | |||
| row.names = c(NA, -5L), class = c("tbl_df", "tbl", "data.frame") | |||
There was a problem hiding this comment.
Need to double check the unit test still behaves but it makes good sense.
changes during meeting w/ @RaymondBalise, @gabrielodom , & @kyleGrealis ref RaymondBalise#59
|
Looks good to me |
close #59