主要兼容性建议 #782
Open
主要兼容性建议 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix[RayWangQvQ#728]: compatible with qinglong history versions
…成unzip错误，安装组件失败，造成的困扰
RayWangQvQ
requested changes
Sep 8, 2024
| # 针对使用fock拉取分支的情况，建议把bili_repo做在环境变量中可以修改调整 | ||
| # 可更兼容性 | ||
| #bili_repo="aspnmy/BiliBiliToolPro" | ||
| bili_repo=${BILI_TRUETRUE_REPONAME:-"raywangqvq/bilibilitoolpro"} |
There was a problem hiding this comment.
是否可以BILI_TRUETRUE_REPONAME改为更好理解的命名
There was a problem hiding this comment.
你自己的项目 你可以自己想一想，如果我取的话，缩减一下可以用 BILI_TRUEUSE_NAME （实际使用路径）
Comment on lines
14
to
17
| #bili_repo="raywangqvq/bilibilitoolpro" # 仓库地址 输入官方分支，或者加速分支目录 | ||
| # 针对使用fock拉取分支的情况，建议把bili_repo做在环境变量中可以修改调整 | ||
| # 可更兼容性 | ||
| #bili_repo="aspnmy/BiliBiliToolPro" |
| qinglong_bili_repo_dir="$(find $dir_repo -type d \( -iname $qinglong_bili_repo -o -iname ${qinglong_bili_repo}_main \) | head -1)" | ||
| #qinglong_bili_repo_dir="$qinglong_bili_repo/podAdmin_BiliBiliToolPro" |
Comment on lines
398
to
415
| # 增加业务逻辑：主要为了解决完成抓不到版本号时造成的更新错误 | ||
| # 可配置环境变量，自定义一个初始值，然后进行下载，避免因为返回值为null而下载不了安装包 | ||
| # bilitool: tag.txt记录的版本：null | ||
| # bilitool: bilitool未安装 | ||
| # bilitool: 开始安装环境 | ||
| # bilitool: 开始安装bilitool | ||
| # bilitool: 最新版本：null | ||
| # bilitool: 下载地址：https://ghproxy.net/https://github.com/RayWangQvQ/BiliBiliToolPro/releases/download/null/bilibili-tool-pro-vnull-linux-musl-x64.zip | ||
| # % Total % Received % Xferd Average Speed Time Time Time Current | ||
| # Dload Upload Total Spent Left Speed | ||
| # 100 9 100 9 0 0 10 0 --:--:-- --:--:-- --:--:-- 10 | ||
| # Archive: bilitool-null.zip | ||
| # End-of-central-directory signature not found. Either this file is not | ||
| # a zipfile, or it constitutes one disk of a multi-part archive. In the | ||
| # latter case the central directory and zipfile comment will be found on | ||
| # the last disk(s) of this archive. | ||
| # unzip: cannot find zipfile directory in one of bilitool-null.zip or | ||
| # bilitool-null.zip.zip, and cannot find bilitool-null.zip.ZIP, period. |
aspnmy2024
reviewed
Sep 9, 2024
Comment on lines
398
to
420
| # 增加业务逻辑：主要为了解决完成抓不到版本号时造成的更新错误 | ||
| # 可配置环境变量，自定义一个初始值，然后进行下载，避免因为返回值为null而下载不了安装包 | ||
| # bilitool: tag.txt记录的版本：null | ||
| # bilitool: bilitool未安装 | ||
| # bilitool: 开始安装环境 | ||
| # bilitool: 开始安装bilitool | ||
| # bilitool: 最新版本：null | ||
| # bilitool: 下载地址：https://ghproxy.net/https://github.com/RayWangQvQ/BiliBiliToolPro/releases/download/null/bilibili-tool-pro-vnull-linux-musl-x64.zip | ||
| # % Total % Received % Xferd Average Speed Time Time Time Current | ||
| # Dload Upload Total Spent Left Speed | ||
| # 100 9 100 9 0 0 10 0 --:--:-- --:--:-- --:--:-- 10 | ||
| # Archive: bilitool-null.zip | ||
| # End-of-central-directory signature not found. Either this file is not | ||
| # a zipfile, or it constitutes one disk of a multi-part archive. In the | ||
| # latter case the central directory and zipfile comment will be found on | ||
| # the last disk(s) of this archive. | ||
| # unzip: cannot find zipfile directory in one of bilitool-null.zip or | ||
| # bilitool-null.zip.zip, and cannot find bilitool-null.zip.ZIP, period. | ||
|
|
||
| tag=${BILI_STORED_TAG:-""} | ||
| url="${github_proxy}https://github.com/RayWangQvQ/BiliBiliToolPro/releases/download/$tag/bilibili-tool-pro-v$tag-$current_os-$machine_architecture.zip" | ||
| say "下载地址：$url" | ||
| echo $url |
There was a problem hiding this comment.
# 增加业务逻辑：主要为了解决完成抓不到版本号时造成的更新错误
关于GitHub有时异常访问，会抓不到基础关键值的问题 比如tag版本号，除了用环境变量手工指定，兼容性上看，你要不和其他作者一样，使用国内的节点做个辅助来源，通过对来访者的ip判断，墙内的直接访问如gitcode的仓库，墙外的访问github，这样安装以后再更新拉库上兼容性更好。
我个人的兼容做法是在国内节点上部署一个私有库，如果GitHub访问有异常数据就会转到我们自己的私有库上去了
```suggestion
# 增加业务逻辑：主要为了解决完成抓不到版本号时造成的更新错误
tag=${BILI_STORED_TAG:-""}
url="${github_proxy}https://github.com/RayWangQvQ/BiliBiliToolPro/releases/download/$tag/bilibili-tool-pro-v$tag-$current_os-$machine_architecture.zip"
say "下载地址：$url"
echo $url
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、建议把部分变量改成全局变量增加兼容性
#781
2、增加业务逻辑：主要为了解决完成抓不到版本号时造成的更新错误 ，提高兼容性
<请描述您将贡献的内容>