Modified for cross-platform compatibility for path to Config.json #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Logger type to ILogger and renamed usages of log to logger. Changed line 39 for config.json path to use method Path.Combine() allowing for cross-platform compatibility.
Changed the Logger type to ILogger and renamed usages of log to logger. Changed line 39 for config.json path to use method Path.Combine() allowing for cross-platform compatibility.
Accidently committed wrong files.
Changed the Logger type to ILogger and renamed usages of log to logger. Changed line 39 for config.json path to use method Path.Combine() allowing for cross-platform compatibility.
Changed the Logger type to ILogger and renamed usages of log to logger. Changed line 39 for config.json path to use method Path.Combine() allowing for cross-platform compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update line 39 in Pegasus.cs to:
ConfigManager.Initialise(Path.Combine(Directory.GetCurrentDirectory(), "Config.json"));The change ensures that the correct path separator is used regardless of the operating system. This modification should make the code compatible with Linux file path conventions while still working on Windows. The Path.Combine() method automatically uses the correct path separator for the current operating system.