Multipolygons #129
Multipolygons #129
Conversation
…feat-multipolygon-brush
…feat-multipolygon-brush
Change FreeFormTool to pixel-based logic and add multipolygon factory
… brush + multipolygon
…teraction while zooming in fftool mode, fixed moving annotations in fftool
|
@simonasarvasova good job. it's really coming close! There was a mode for this tool that allowed remove/add on right/left click: which does not work anymore. It should route left click to 'add' right to 'remove', functionality, ignoring the presets. It should not create new annotations. |
| } | ||
|
|
||
| exportsGeometry() { | ||
| return ["path"]; |
There was a problem hiding this comment.
Before merging I would also like to have working export to geojson + asap xml formats, I was thinking about helping there but I realized the export contains 'path'. Is this computable without having the 'path' exported using the points only? I would propose
exportsGeometry() {
return ["points"];
and remove the path from any export, have it computed on load time...
Then, each convertor could only work with 'points'. Which is more standard way.
|
@Aiosa sorry what's wrong with the fftool correction again? It's working as you describe when I try it. |
|
Sorry, my mistake. It works. |
|
The only issue I see here now is then with the exporting abilities + path prop described above... |
| return new Promise((resolve, reject) => { | ||
| input.objects.forEach(obj => { |
There was a problem hiding this comment.
More or less okay, but I would - for nicencess, add the execution of the logics to the factory, so it can do whatever it wishes to... I will add at least a todo comment
|
@simonasarvasova small bug: if I select + brush, and then switch to viweport segmentation, it still does brushing likely caused the fact that I run no slides/masks just the default not found page: |
|
@simonasarvasova I fixed it :) |
|
Added few more fixes, LGTM. Great job! |
Adds ability to brush with multipolygons.