Tidy up how Code Editor and Code Classroom users can provide feedback#1486
Merged
Conversation
abcampo-iry
temporarily deployed
to
previews/1486/merge
GitHub Actions
Inactive
abcampo-iry
changed the title
abcampo-iry
temporarily deployed
to
previews/1486/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Info panel “Feedback” link configurable for editor-wc hosts (e.g. Code Classroom) via a new feedback_form_url attribute, while keeping the Code Editor feedback form as the default.
Changes:
- Added
feedback_form_urlas an observededitor-wcattribute and threaded it through the loader and project views into the sidebar. - Updated
InfoPanelto acceptfeedbackFormUrland updated tests to cover the default and custom URL cases. - Documented the new web component attribute in the README.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web-component.js | Adds feedback_form_url to observed attributes so hosts can configure it. |
| src/containers/WebComponentLoader.jsx | Accepts feedbackFormUrl and passes it down to the project view. |
| src/components/WebComponentProject/WebComponentProject.jsx | Threads feedbackFormUrl into mobile/desktop project render paths. |
| src/components/Mobile/MobileProject/MobileProject.jsx | Passes feedbackFormUrl into the sidebar in mobile layout. |
| src/components/Menus/Sidebar/Sidebar.jsx | Wires feedbackFormUrl into the Info panel. |
| src/components/Menus/Sidebar/InfoPanel/InfoPanel.jsx | Uses the provided feedbackFormUrl for the feedback link (with default). |
| src/components/Menus/Sidebar/InfoPanel/InfoPanel.test.js | Refactors rendering helper and adds coverage for default/custom URL. |
| src/components/Editor/Project/Project.jsx | Threads feedbackFormUrl into the sidebar in the desktop project view. |
| README.md | Documents the new feedback_form_url attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abcampo-iry
temporarily deployed
to
previews/1486/merge
GitHub Actions
Inactive
abcampo-iry
temporarily deployed
to
previews/1486/merge
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1405
Details