-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): supervisord controlled container #12
base: master
Are you sure you want to change the base?
Conversation
This change makes raspap-docker use supervisord instead of systemd. The current version is tested to be functional with "out of the box connectivity". More work is needed to support process restarts from config changes (possibly in raspap-webgui). The docker container uses the raspap-ansible repo with a slightly modified playbook. There are a few more outstanding issues that need addressed: 1. dhcpcd is not playing nicely inside the container. To get a static ip on wlan0 I had to put the RaspAP config outside of the container on the host's dhcpcd. 2. iptable rules need to be handled at 'docker run' time, not at docker build time (where they are excluded) 3. Configuration should be able to persist if a new version of the raspap docker image comes out. Basically let's support volume mounts 4. A good way to depend on raspap-ansible. Is a submodule overkill? Good enough to git clone inside the docker build? This PR is a work-in-progress.
Web GUI should be accessible on http://localhost by default | ||
``` | ||
Copy `dhcpcd.conf` over your `/etc/dhcpcd.conf` file. We're using the `dhcpcd` binary on the host system, but disabling it from managing `wpa_supplicant`. `wpa_supplicant` is managed inside the RaspAP container. | ||
`docker run --name raspap -it -d --privileged jrcichra/raspap-docker` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement a build system and reference container here (ghcr.io/raspap/raspap-docker)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like PRs are building to latest - need to change some of the tagging around.
This change makes raspap-docker use supervisord instead of systemd.
The current version is tested to be functional with "out of the box connectivity".
More work is needed to support process restarts from config changes (possibly in raspap-webgui).
The docker container uses the raspap-ansible repo with a slightly modified playbook.
There are a few more outstanding issues that need addressed:
This PR is a work-in-progress.