feat(v2): supervisord controlled container #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes raspap-docker use supervisord instead of systemd. The current version is tested to be functional with "out of the box connectivity". More work is needed to support process restarts from config changes (possibly in raspap-webgui). The docker container uses the raspap-ansible repo with a slightly modified playbook. There are a few more outstanding issues that need addressed: 1. dhcpcd is not playing nicely inside the container. To get a static ip on wlan0 I had to put the RaspAP config outside of the container on the host's dhcpcd. 2. iptable rules need to be handled at 'docker run' time, not at docker build time (where they are excluded) 3. Configuration should be able to persist if a new version of the raspap docker image comes out. Basically let's support volume mounts 4. A good way to depend on raspap-ansible. Is a submodule overkill? Good enough to git clone inside the docker build? This PR is a work-in-progress.
jrcichra
commented
Jul 30, 2022
jrcichra
commented
Jul 30, 2022
| Web GUI should be accessible on http://localhost by default | ||
| ``` | ||
| Copy `dhcpcd.conf` over your `/etc/dhcpcd.conf` file. We're using the `dhcpcd` binary on the host system, but disabling it from managing `wpa_supplicant`. `wpa_supplicant` is managed inside the RaspAP container. | ||
| `docker run --name raspap -it -d --privileged jrcichra/raspap-docker` |
There was a problem hiding this comment.
Implement a build system and reference container here (ghcr.io/raspap/raspap-docker)?
There was a problem hiding this comment.
It looks like PRs are building to latest - need to change some of the tagging around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes raspap-docker use supervisord instead of systemd.
The current version is tested to be functional with "out of the box connectivity".
More work is needed to support process restarts from config changes (possibly in raspap-webgui).
The docker container uses the raspap-ansible repo with a slightly modified playbook.
There are a few more outstanding issues that need addressed:
This PR is a work-in-progress.