Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Models and Project for RAT API #6

Merged
merged 20 commits into from
Aug 21, 2023
Merged

Add Models and Project for RAT API #6

merged 20 commits into from
Aug 21, 2023

Conversation

DrPaulSharp
Copy link
Collaborator

No description provided.

@DrPaulSharp
Adds "models.py" with initial draft of pydantic models for API classes
c277ed0
@DrPaulSharp
Adds validators for pydantic models
98851d5
@DrPaulSharp
Fixes parameter names in background model
5ffb29b
@DrPaulSharp
Adds new model ProtectedParameter
75be6f6
@DrPaulSharp
Adds "project.py" with initial draft of the high level "Project" class
4e66327
@DrPaulSharp
Adds "model_post_init" routine for the "project" model
b1f4574
@DrPaulSharp
Adds "__repr__" routine for the "project" model
a05b35a
@DrPaulSharp
Adds code to work with updated ClassList
2ede5a1
@DrPaulSharp
Moves validators to cross-check project fields from "models.py" to "p…
760e686 
…roject.py"
@DrPaulSharp
Replaces annotated validators with single field validator in "project…
d216c8c 
….py"
@DrPaulSharp
Add contrasts to cross-checking model validator in "project.py"
5e98ba0
@DrPaulSharp
Changes data model to accept numpy array
035511c
@DrPaulSharp
Adds docs and modifies the Project class's "model_post_init" to ensur…
e39a252 
…e all ClassLists have the correct "_class_handle"
@DrPaulSharp
Adds tests "test_models.py"
a5aeb48
@DrPaulSharp
Removes unused routine "get_all_names" from "project.py"
19051e6
@DrPaulSharp
Adds tests "test_project.py"
2ca3aa3
@DrPaulSharp
Tidies up model and project classes and tests
4b69089
StephenNneji
StephenNneji approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@StephenNneji StephenNneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see comments

tests/test_project.py
RAT.models.Layer,
RAT.models.Resolution,
])
def test_initialise_wrong_classes(model: Callable) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is typing the test necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not necessary, but helps pycharm with catching errors etc.

@DrPaulSharp DrPaulSharp merged commit c9b74c0 into RascalSoftware:main Aug 21, 2023
@DrPaulSharp DrPaulSharp deleted the models branch August 21, 2023 11:31
@DrPaulSharp DrPaulSharp mentioned this pull request Aug 25, 2023
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenNneji StephenNneji StephenNneji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrPaulSharp @StephenNneji