Adds align profile, quick Bayesian exit, fixes bug in data background and BlittingSupport #212
Open
StephenNneji wants to merge 4 commits into
Open
Adds align profile, quick Bayesian exit, fixes bug in data background and BlittingSupport #212StephenNneji wants to merge 4 commits into
StephenNneji wants to merge 4 commits into
Conversation
StephenNneji
force-pushed
the
align_profile
branch
from
dc69467 to
81aaab6
Compare
StephenNneji
changed the title
DrPaulSharp
reviewed
Jul 15, 2026
| if background.type == TypeOptions.Data: | ||
| contrast_background_param.append(project.data.index(background.source, True)) | ||
| # Background data is appended to contrast data so empty index | ||
| contrast_background_param.append(np.array([])) |
Collaborator
There was a problem hiding this comment.
Do you need to append an empty array here given that contrast_background_param is defined as an empty array on line 243?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MATLABOpaqueobject which caused some tests to start failing. I have added__opaque_to_stringto load both old and new format. But I still fix the scipy version to 1.17.1 in case any other breaking changes existBlittingSupportit assumed that plot will always have data