-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds custom file tab to project widget #61
Conversation
7afd79a
to
ebf2490
Compare
b39c595
to
4abd925
Compare
0f4422c
to
c3744d1
Compare
c3744d1
to
4d3872a
Compare
4d3872a
to
1afd794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
I think the filename should be stored as a relative path from the project directory, using an absolute path will make it so the project will not run if it is moved to another directory even though the custom file is in the same directory. Also the DSPC_custom_layers example crashes when I try to set the function because the path is stored as "examples/DSPC_custom_layers" whereas the path should be empty for a file in the same project directory
Also have an issue with the column size, out of the box the function name column clips the text
Also in edit mode it is possible to resize the columns so the button is not visible
I also cannot change the size of the name column directly, although the size can change if I change another column. Not sure if this is a bug or something intended but I don't think the behaviour is good as my first instinct is to reduce the size of the largest column then I find out I can't
@StephenNneji on the section resizes:
I'm also not quite sure how to make the name column resizable while also having it stretch to fill available space. This is the default behaviour of |
8b71ccf
to
7d0e43b
Compare
This PR adds the Custom Files tab to the project widget. Fixes #45.