Raises errors if attempt to use function or data backgrounds #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhroom
changed the title
alexhroom
force-pushed
the
245-unsupported-backs
branch
from
0e6161d to
a98f76d
Compare
alexhroom
force-pushed
the
245-unsupported-backs
branch
from
a98f76d to
4b2225b
Compare
DrPaulSharp
reviewed
Aug 5, 2024
tests/testBackgroundsClass.m
Outdated
| % string(testCase.backgrounds(3, :)), 'addBackground method not working'); | ||
| %testCase.background.addBackground(testCase.backgrounds{4, :}); | ||
| %testCase.verifyEqual(string(testCase.background.backgrounds.varTable{end, :}),... | ||
| % string(testCase.backgrounds(4, :)), 'addBackground method not working'); |
There was a problem hiding this comment.
Given the changes to the test input data, can these lines be uncommented?
tests/testBackgroundsClass.m
Outdated
| % 'addBackground method not working'); | ||
| %testCase.verifyError(@() testCase.background.addBackground('New', 'fixed'), exceptions.invalidOption.errorID); | ||
| %testCase.verifyError(@() testCase.background.addBackground('New', allowedTypes.Constant), exceptions.invalidNumberOfInputs.errorID); | ||
| %testCase.verifyError(@() testCase.background.addBackground('New', allowedTypes.Constant.value, 6), exceptions.indexOutOfRange.errorID); |
There was a problem hiding this comment.
The three lines here testing the errors can be uncommented too.
tests/testBackgroundsClass.m
Outdated
| testCase.verifyError(@() testCase.background.setBackground(2, 'type', 'random'), exceptions.invalidOption.errorID); | ||
| %testCase.background.setBackground('Background 1', 'type', allowedTypes.Function); | ||
| %testCase.verifyEqual(testCase.background.backgrounds.varTable{1, 2}, string(allowedTypes.Function.value), 'setBackground method not working'); | ||
| %testCase.verifyError(@() testCase.background.setBackground(2, 'type', 'random'), exceptions.invalidOption.errorID); |
tests/testBackgroundsClass.m
Outdated
| %testCase.background.setBackground(3, 'Value1', 'random'); | ||
| %testCase.verifyEqual(testCase.background.backgrounds.varTable{3, 3}, "random", 'setBackground method not working'); | ||
| %testCase.background.setBackground('Background 3', 'Value1', 'Background param 1'); | ||
| %testCase.verifyEqual(testCase.background.backgrounds.varTable{3, 3}, "Background param 1", 'setBackground method not working'); |
There was a problem hiding this comment.
can't uncomment 142-143 as i'd changed background 3 to a constant background - Value1 of a constant background is validated but Value1 of a function background is not, so you can't just arbitrarily set Value1 for a test unless the background type is function
DrPaulSharp
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245 by adding a new exception type
notImplementedand raises it if the user attempts to use a data or function background.Presently, the relevant test parts have been commented out. If someone thinks it's better to remove them entirely, please let me know.