Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rich role.move interface #10100

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Conversation

LeoCx1000
Copy link
Contributor

Summary

This PR is a continuation of #9853 and implements a rich Role.move interface to supersede role.edit(position=...), as it's unreliable because roles can have duplicated positions and holes in the ordering. #bikeshedding thread

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue. Technically?
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems mostly okay I suppose.

The library uses single quotes instead of double quotes though.

discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
discord/role.py Outdated Show resolved Hide resolved
@LeoCx1000 LeoCx1000 requested a review from Rapptz February 9, 2025 10:21
@Rapptz Rapptz merged commit 8edf433 into Rapptz:master Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants