This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
Updated package to support media:content tag #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added classes to support all media tags |
|
Hi Team, Let me know if this works for your or let me know if I should withdraw the PR. Thanks |
|
I just haven’t had a chance to look at it yet. No need to withdraw! I’m just slow :) |
brentsimmons
suggested changes
May 13, 2023
| @@ -168,6 +172,12 @@ - (RSParsedFeed *)parseFeed { | |||
| static const char *kEnclosure = "enclosure"; | |||
| static const NSInteger kEnclosureLength = 10; | |||
|
|
|||
| static const char *kMediaContent = "media"; | |||
| static const NSInteger kMediaContentLength = 10; | |||
There was a problem hiding this comment.
The 10 should be 6 — m-e-d-i-a plus a null character is 6 characters.
| static const NSInteger kMediaContentLength = 10; | ||
|
|
||
| static const char *kMediaCredit = "credit"; | ||
| static const NSInteger kMediaCreditLengt = 10; |
There was a problem hiding this comment.
kMediaCreditLengt is missing an h at the end — should be kMediaCreditLength
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic to parse media:content tag on RSSParser.
Created a new object (RSParsedMediaContent) and use it to add attachments elements when they exist.