Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drenv: create mcsb for "argocd" ns during installation #1939

Merged
merged 1 commit into from
Mar 18, 2025
Merged

drenv: create mcsb for "argocd" ns during installation #1939

merged 1 commit into from
Mar 18, 2025

Conversation

parikshithb
Copy link
Member

@parikshithb parikshithb commented Mar 18, 2025 •
edited
Loading

This change handles mcsb creation for "argocd" namespace for default clusterset during drenv cluster installation similar to how it is configured by users for "openshift-gitops" namespace in openshift env. With this change we do not need to handle create/delete mcsb in e2e for appset apps.

tested locally, mcsb got created:

- apiVersion: cluster.open-cluster-management.io/v1beta2
  kind: ManagedClusterSetBinding
  metadata:
    creationTimestamp: "2025-03-18T11:04:35Z"
    generation: 1
    name: default
    namespace: argocd
    resourceVersion: "1778"
    uid: 3a6cd4b6-a6ab-4883-8af5-ce4bb7510500
  spec:
    clusterSet: default
  status:
    conditions:
    - lastTransitionTime: "2025-03-18T11:04:35Z"
      message: ""
      reason: ClusterSetBound
      status: "True"
      type: Bound

Fixes #1921

@parikshithb parikshithb removed the request for review from raghavendra-talur March 18, 2025 11:31
@parikshithb parikshithb marked this pull request as draft March 18, 2025 12:02
@parikshithb
drenv: create mcsb for "argocd" ns during installation
2e7ed66 
This change handles mcsb creation for "argocd" namespace
for default clusterset during drenv cluster installation
similar to how it is configured by users for "openshift-gitops"
namespace in openshift env. With this change we do not need
to handle create/delete mcsb in e2e.

Signed-off-by: Parikshith <[email protected]>
@parikshithb parikshithb marked this pull request as ready for review March 18, 2025 14:44
nirs
nirs approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@nirs
Copy link
Member

nirs commented Mar 18, 2025

This fixes a very bad bug when we delete user created content from the cluster. We should make it clear in the commit message.

Fixes #1921

@nirs nirs merged commit c975f8c into RamenDR:main Mar 18, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirs nirs nirs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e: existing managedclusterbinding deleted on openshift clusters
2 participants
@parikshithb @nirs