e2e: create namespace and annotate based on distro #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parikshithb please link to issue |
nirs
reviewed
Mar 17, 2025
parikshithb
force-pushed
the
e2e_annotate
branch
from
7173e7c to
380a2de
Compare
parikshithb
force-pushed
the
e2e_annotate
branch
from
380a2de to
a1c553e
Compare
nirs
reviewed
Mar 18, 2025
parikshithb
force-pushed
the
e2e_annotate
branch
from
a1c553e to
2feb3dd
Compare
nirs
reviewed
Mar 21, 2025
Signed-off-by: Parikshith <[email protected]>
- Create namespace only on DRCluster(c1) before deploying discovered app instead of using CreateNamespaceAndAddAnnotation which is not required. - Add CreateNamespacesDiscoveredApps() after protecting discovered app to handle create namespace and annotate or just creates the app namespace on target dr cluster based on Kubernetes distribution. - In EnableProtection for managed apps, create namespaces only for Kubernetes (DistroK8s) with VolSync annotation using the helper function createNamespaces(). since it is not required of openshift since ACM handles it. - Ignore cyclomatic complexity check for EnableProtection which needs refactoring in future. Signed-off-by: Parikshith <[email protected]>
parikshithb
force-pushed
the
e2e_annotate
branch
from
2feb3dd to
7e6a76c
Compare
nirs
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exports distro constants in config package and based on distro creates namespace/annotates during deploy and protection.
Fixes #1919