vrg: fix KubeObjectProtected and KubeObjectsReady condition #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
force-pushed
the
rtalur-fix-kube-conditions
branch
from
0076ea0 to
6ba554a
Compare
raghavendra-talur
force-pushed
the
rtalur-fix-kube-conditions
branch
from
6ba554a to
25ee364
Compare
It was confusing to read backup messages during the restore operations. Signed-off-by: Raghavendra Talur <[email protected]>
Earlier, we were leaving the name as empty string making the backup name hard to find. Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
The condition has to be initialized correctly at the start of the reconcile to false condition. Later we set it to - nil if kube object protection is disabled - true if the kube objects were captured with the capture interval Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-fix-kube-conditions
branch
from
25ee364 to
f48f881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO