Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log metrics value #1806

Closed
wants to merge 1 commit into from
Closed

log metrics value #1806

wants to merge 1 commit into from

Conversation

rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Feb 5, 2025 •
edited
Loading

log metrics value.

@rakeshgm
log metrics value
0bc627a 
Signed-off-by: rakeshgm <[email protected]>
@rakeshgm rakeshgm requested a review from ShyamsundarR February 5, 2025 10:36
ShyamsundarR
ShyamsundarR reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@ShyamsundarR ShyamsundarR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there is value in logging the metric, I am not for additional logging at the moment. The metrics are scraped by prometheus and should be available for time series inspection. I suggest that we close this PR

@rakeshgm rakeshgm closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShyamsundarR ShyamsundarR ShyamsundarR left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakeshgm @ShyamsundarR