-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in updates for 32/64 data and code cleanup #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prep for creating JSON output
I've tested the CMake build on 32-bit Ubuntu 16, 64-bit Ubuntu 18, 64-bit Ubuntu 20, and Windows 10 using CLion (with its default gcc installation). |
Updated links to the new organization. Removed Makefile references. Removed reference to old configuration file.
fixed typo removed obsolete "orders" command updated examples and command descriptions
and usage text
Updated code to use the cJSON library.
initial tests pass
added a test script, too
ran too fast with too few tests
removed `show version` updated documentation
with hidden magic values
with hidden magic values
use cJSON for everything combine files to make it easier to edit
updated export to match
Merge branch 'enh/import-json' into main
The test compared the binary data after importing. This failed on unused, reserved, and padded fields. Updated the export and import to be more careful about clearing out buffers and added all of the fields so that the binary files would be identical.
Annoying and caused compile errors since it used a non-standard macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed (most) compiler warnings.
Changed Make to CMake.
Consolidated entrypoint into single executable (note: still need to update tools to use!).
Added export/import as JSON for sharing and editing.
Merged in Raven's changes.
Fixes #7