Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio and quinn upgrade #220

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Conversation

patowen
Copy link
Collaborator

@patowen patowen commented Jun 19, 2022

This PR contains the following related changes:

  • Upgrade tokio from 0.2.13 to 1.18.2
  • Upgrade quinn from 0.6.1 to 0.8.3
  • Upgrade rustls from 0.17.0 to 0.20.6

Due to non-backwards-compatible changes in the way quinn/rustls handles certificates, some logic in that area needed to change.

A few items still need to be completed before I'm fully comfortable merging this.

  • Test that a client can connect to a server when the server gets a certificate from a file.
  • Consider documenting certificate generation commands that can be used to test.

@patowen
Copy link
Collaborator Author

patowen commented Jun 19, 2022

I was able to get a certificate pair that the server accepted with the help of the following openssl command in Windows git bash (source: denoland/deno#13350 (comment)):

MSYS_NO_PATHCONV=1 openssl req -new -x509 -nodes -days 365 -text -subj "/CN=localhost" -extensions v3_req \
     -keyout server.key -out server.crt

followed by converting server.crt into a pem file.

Given that I believe multiplayer is very much a work in progress, I'm happy just using this PR comment as documentation of a working certificate generation command.

Copy link
Owner

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FWIW, certificates are intended to be optional--if you don't provide one, the server should generate its own.

@Ralith Ralith merged commit 2da2010 into Ralith:master Jun 20, 2022
@patowen
Copy link
Collaborator Author

patowen commented Jun 20, 2022

True. I had tested that first, but the ability to set up your own certificate pair is a feature that I could have broken, so I wanted to test that to ensure that this PR didn't cause a regression.

@Ralith
Copy link
Owner

Ralith commented Jun 20, 2022

Fair enough; thanks for the rigor!

@patowen patowen deleted the tokio-and-quinn-upgrade branch June 20, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants