Makefile: add diff output for python linter if there are some warnings #2108
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add diff output for python linter if there are some warnings.
What is the current behavior?
If there is a warning about python code style, then it will be just a generic summary warning, so to fix a code style, a contributor has to enable
--diffoption, run tests again, fix code style, run tests again, and remove--diffoption.What is the new behavior (if this is a feature change)?
Add
--diffoption by default to build scripts, so just like in case withclang-format, a contributor could see file names and lines of code related to a warning.Other information:
Suggested approach makes workflow more convenient.