Merged
Conversation
06f07ac to
e942e31
Compare
Collaborator
Author
|
Updated docker test image to include aspell/aspell-en. committed a fake word to a test file. Now getting: |
Move all xt/ files to t/ and update references Part of #4788
Collaborator
Author
bffa2f7 to
8570acf
Compare
... which only seems to happen in the container
Collaborator
Author
|
Cleaned up and tested on the branch with a bad word that was correctly reported on. Thanks to @ShimmerFairy for the --encoding pointer! Many force pushes to try things out, test a bad word, clean everything up; down to 2 clean commits for the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Since this isn’t checked as part of CI but only author tests (xt/), we often miss typos until after we merge the PR.
Solution provided
Move to t/, might have to update CI to have the correct packages.
Closes #4788