Skip to content

Move aspell to CI tests#4789

Merged
coke merged 2 commits intomainfrom
coke/aspell
Mar 2, 2026
Merged

Move aspell to CI tests#4789
coke merged 2 commits intomainfrom
coke/aspell

Conversation

@coke
Copy link
Copy Markdown
Collaborator

@coke coke commented Feb 23, 2026

The problem

Since this isn’t checked as part of CI but only author tests (xt/), we often miss typos until after we merge the PR.

Solution provided

Move to t/, might have to update CI to have the correct packages.

Closes #4788

@coke coke marked this pull request as draft February 23, 2026 16:30
@coke coke marked this pull request as ready for review February 23, 2026 16:30
@coke coke marked this pull request as draft February 23, 2026 16:30
@coke coke marked this pull request as ready for review February 23, 2026 16:38
@coke coke force-pushed the coke/aspell branch 3 times, most recently from 06f07ac to e942e31 Compare February 23, 2026 16:48
@coke
Copy link
Copy Markdown
Collaborator Author

coke commented Feb 23, 2026

Updated docker test image to include aspell/aspell-en.

committed a fake word to a test file. Now getting:

A worker in a parallel iteration (hyper or race) initiated here:
  in block <unit> at t/23-aspell.rakutest line 71
Died at:
    A react block:
      in block  at t/23-aspell.rakutest line 105
    Died because of the exception:
        Malformed UTF-8 near bytes 65 e2 20
                                                   
t/23-aspell.rakutest ................ Dubious, test returned 255
All 2 subtests passed 

Move all xt/ files to t/ and update references

Part of #4788
@coke
Copy link
Copy Markdown
Collaborator Author

coke commented Feb 28, 2026

This is very similar to #3339 and #4156

@coke coke force-pushed the coke/aspell branch 3 times, most recently from bffa2f7 to 8570acf Compare March 2, 2026 04:14
... which only seems to happen in the container
@coke coke merged commit cd39ee2 into main Mar 2, 2026
1 check passed
@coke coke deleted the coke/aspell branch March 2, 2026 04:20
@coke
Copy link
Copy Markdown
Collaborator Author

coke commented Mar 2, 2026

Cleaned up and tested on the branch with a bad word that was correctly reported on. Thanks to @ShimmerFairy for the --encoding pointer!

Many force pushes to try things out, test a bad word, clean everything up; down to 2 clean commits for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run aspell test as part of CI

1 participant