Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User resource 2 #135

Closed
wants to merge 7 commits into from
Closed

User resource 2 #135

wants to merge 7 commits into from

Conversation

sibsmc
Copy link
Collaborator

@sibsmc sibsmc commented Jun 30, 2019

Creates a user database called 'ApiUser'
CRUD APIs have been created
A series of tests in Spec have been created for the CRUD APIs

I started to look into authentication, hence these three files:
server/spec/auth/authorize_api_request_spec.rb
server/app/lib/json_web_token.rb
server/app/auth/authenticate_user.rb
however these don't serve any purpose at the moment, no authentication required.

Test can be run by running command 'bundle exec rspec spec'

sibsmc added 7 commits June 18, 2019 20:00
Also contains user database migration and database seed.
…with command 'rspec spec/requests/api/v1/users_spec.rb' in the server directory.
…so that I can call individual accounts via API
…formation form this ApiUser database, also created a series of tests for these Apis.
CRUD APIs have been created
A series of tests in Spec have been created for the CRUD APIs
@sibsmc sibsmc requested a review from a team June 30, 2019 14:59
@sibsmc sibsmc added the backend Issue for backend team label Jun 30, 2019
@sibsmc sibsmc closed this Jul 1, 2019
@sibsmc
Copy link
Collaborator Author

sibsmc commented Jul 1, 2019

Closed this pull request and pushed changes to original user resource pull request 'Pull Request for User Resource only #75' in order to maintain history.

@nynnejc
Copy link
Member

nynnejc commented Jul 1, 2019

This looks great from my quick glance, @sibsmc. What is the culture around closing our own pull requests? I'm used to a general convention that when you make a PR then you always get someone else to look it over and approve it and only then can you merge. If no one is reacting to your PR, then you can assign them as reviewers. Perhaps you talked about this already i a meeting? If not, I do suggest that we use the chance for reviewing PRs also as a way to learn from each other. Happy to take this discussion over to slack if anyone else have thoughts on it.

@sibsmc
Copy link
Collaborator Author

sibsmc commented Jul 1, 2019

Hi I think what I wrote above is confusing. I have closed my two new pull requests without merging anything: #134 and #135 , and then I pushed the local changes I had worked on, to my original pull request #75, which is what I should have done instead of opening #134 and #135. PR #75 is not merged and is awaiting review. Definitely agree we should get a review before merging pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue for backend team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants