feat: add funding observation #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134dd3v
commented
May 14, 2022
| let observation = new FundingObservation(observationId); | ||
| observation.pool = pool.id; | ||
| observation.timestamp = timestamp; | ||
| observation.fundingRate = getFundingRate(BigInt.fromString(pool.id)); |
There was a problem hiding this comment.
Can you review if converting hex string to BigInt here is correct?
There was a problem hiding this comment.
BigInt.fromString(pool.id) not enough confidence in this one.
You can try -
let bytes = ByteArray.fromHexString(hexString)
let poolIdBigInt. = BigInt.fromSignedBytes(bytes)But I don't like that too much either, why can't you access the BigInt version of poolId from the event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.