Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Parse Exception Groups QxR TAoE SMURF #7814

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

New: Parse Exception Groups QxR TAoE SMURF #7814

wants to merge 5 commits into from

Conversation

bccornfo
Copy link

@bccornfo bccornfo commented Nov 30, 2022 •
edited
Loading

Update ExceptionReleaseGroupRegex with a number of release groups

Database Migration

NO

Description

This pull request aims to add a number of release groups that appear to follow the - RLSGROUP) format.

Screenshot (if UI related)

Todos

  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

Issues Fixed or Closed by this PR

  • Fixes N/A

bakerboy448
bakerboy448 suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@bakerboy448 bakerboy448 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests are required for parser changes. Please don't check the box indicating you've added tests when you did not.
  • This change breaks existing tests...QxR is not the group.
    should_parse_exception_release_group("Movie Name (2003) (2160p BluRay X265 HEVC 10bit HDR AAC 7.1 Tigole) [QxR]","Tigole")

the format of the exception group is not -GROUP) it is GROUP) or GROUP]. Any group that's -GROUP is already recognized

@bakerboy448 bakerboy448 added Area: Parser Issue is related to parsing infrastructure. Status: Waiting for OP Action Required from OP Status: Don't Merge Hold up - don't merge this labels Nov 30, 2022
@bccornfo
Copy link
Author

  • Tests are required for parser changes. Please don't check the box indicating you've added tests when you did not.

    • This change breaks existing tests...QxR is not the group.
      should_parse_exception_release_group("Movie Name (2003) (2160p BluRay X265 HEVC 10bit HDR AAC 7.1 Tigole) [QxR]","Tigole")

the format of the exception group is not -GROUP) it is GROUP) or GROUP]. Any group that's -GROUP is already recognized

Added tests for the groups added to the ExceptionReleaseGroupRegex.

@bccornfo bccornfo requested review from bakerboy448 and Qstick and removed request for bakerboy448 and Qstick December 7, 2022 13:59
@bakerboy448 bakerboy448 added Status: Ready for Review Awaiting review and removed Status: Waiting for OP Action Required from OP Status: Don't Merge Hold up - don't merge this labels Dec 7, 2022
@bakerboy448 bakerboy448 changed the title Update Parser.cs New: Parse Groups QxR TAoE Dec 7, 2022
@bakerboy448 bakerboy448 changed the title New: Parse Groups QxR TAoE New: Parse Groups QxR TAoE SMURF Dec 7, 2022
@bakerboy448 bakerboy448 changed the title New: Parse Groups QxR TAoE SMURF New: Parse Exception Groups QxR TAoE SMURF Dec 7, 2022
@bakerboy448 bakerboy448 added conflict conflict - cannot merge, needs resolution and removed Status: Ready for Review Awaiting review labels Mar 1, 2023
@bakerboy448 bakerboy448 removed the request for review from Qstick March 1, 2023 04:11
@bakerboy448 bakerboy448 added the Status: Waiting for OP Action Required from OP label Mar 1, 2023
@grapexy
Copy link

grapexy commented Apr 28, 2023

Just wanted to chime in here before/if this gets merged: TAoE and QxR are not 1:1 mapping to groups, they're more akin to a super-group, or an organization. Their releases differ greatly and frequently do not have this super-group in filenames or even release names sometimes, but they always have their "member" name. So for purposes of *arrs, "Tigole" and "Goki" should be a parsed group, not "QxR" or "TAoE".

@bakerboy448
Copy link
Contributor

bakerboy448 commented Jun 6, 2023 •
edited
Loading

needs to be rebased & deconflicted also grapexy's comment has a point..

@bccornfo
Update Parser.cs
0b1c564 
Update ExceptionReleaseGroupRegex with a number of release groups
@bccornfo
Update Parser.cs
c35d40d 
Remove duplicated SEV group in ExceptionReleaseGroupRegex
@bccornfo
Update ReleaseGroupParserFixture.cs
5fddf9a 
Add tests to cover exception release groups added
@bccornfo
Update ReleaseGroupParserFixture.cs
94f7132 
Change incorrect test case for group Tigole when QxR is present
@bccornfo
Copy link
Author

bccornfo commented Jun 6, 2023

needs to be rebased & deconflicted also grapexy's comment has a point..

Rebased

@bccornfo
Update Parser.cs
32cfb48 
Update ExceptionReleaseGroupRegex with a number of release groups
@bccornfo bccornfo requested a review from bakerboy448 June 6, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qstick Qstick Qstick requested changes

@bakerboy448 bakerboy448 Awaiting requested review from bakerboy448

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Area: Parser Issue is related to parsing infrastructure. conflict conflict - cannot merge, needs resolution Status: Waiting for OP Action Required from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bccornfo @grapexy @bakerboy448 @Qstick