Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add func getting memes array and returning random meme string #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add func getting memes array and returning random meme string #463

wants to merge 1 commit into from

Conversation

volkfm98
Copy link

No description provided.

MeguminSama
MeguminSama suggested changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@MeguminSama MeguminSama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to return the function as a prototype.

Just add anything.prototype.getRandomMeme = getRandomMeme; to the end of the module and it be gucci

Rabrennie
Rabrennie requested changes Oct 13, 2018
View reviewed changes
Copy link
Owner

@Rabrennie Rabrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs adding to the prototype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeguminSama MeguminSama MeguminSama requested changes

@Rabrennie Rabrennie Rabrennie requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@volkfm98 @Rabrennie @MeguminSama