-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add preview of AmpForm-DPD model deserialization #47
Conversation
@mmikhasenko the page has been converted from a Jupyter notebook with MyST syntax and is not yet optimal for Quarto. On the road today, hope to get back to that later today. The PR should be merged before tomorrow afternoon. |
Looks great, @redeboer. |
p^{2L} is missing. my form-factor includes z^{2l} in the numerator, that is why there is no p^{2l+1} in julia code. Just 2p/sqrt{s} |
For that it would be easiest to get a section with checksums for dynamics. But indeed perhaps the points you pointed out might fix it already. |
I'm doubting btw between merging this PR for now to get at least the preview up or addressing the issues first. Don't think I can handle that quickly because it might require a new prerelease of AmpForm-DPD. |
These are output files by Quarto if there are `qmd` files
Good point, though more of a design problem + latex rendering problem? You would just have to square the mass. But yeah if there is some argument swapping going on programmatically this is tricky... |
@mmikhasenko seeing that CI takes some time, I would prefer to merge this one (and #45?) asap. Remaining issues will be addressed through ComPWA/ampform-dpd#133 and a follow-up PR here. |
Ah sorry, hadn't noticed that the requirement for an approval was switched off... so it automerged already |
Added a page for Lc to pKpi that illustrates ComPWA/ampform-dpd#132 (preview).
Warning
The model validation does not work yet, for now the page just illustrates the symbolic rendering of the deserialized model. Keep an eye on ComPWA/ampform-dpd#133 for upcoming fixes.