Exp consistent lifespans #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandypreiss
reviewed
May 29, 2024
There was a problem hiding this comment.
Requesting the merge into exp-crccp-replication is causing a lot of diffs that we don't want. (We want to keep exp-crccp-replication as a record of that specific experiment, not copy exp-consistent-lifespans into it.)
I think the better place to put this change to the summary script is in the experiment-template branch. You can check out experiment-template, branch off of that and make the changes in that branch, then request to merge it into experiment-template.
crcsim/experiment/summarize.py
Outdated
Comment on lines
130
to
163
| # Create a second sheet with select columns | ||
| select_columns = ["scenario", | ||
| "Colonoscopy_performed_diagnostic_per_1k_40yo_mean", | ||
| "Colonoscopy_performed_surveillance_per_1k_40yo_mean", | ||
| "FIT_performed_routine_per_1k_40yo_mean", | ||
| "clin_crc_per_1k_40yo_mean", | ||
| "deadcrc_per_1k_40yo_mean", | ||
| "lifeobs_if_unscreened_undiagnosed_at_40_mean", | ||
| "discounted_cost_routine_mean", | ||
| "discounted_cost_diagnostic_mean", | ||
| "discounted_cost_surveillance_mean", | ||
| "discounted_cost_treatment_initial_mean", | ||
| "discounted_cost_treatment_ongoing_mean", | ||
| "discounted_cost_treatment_terminal_mean", | ||
| "cost_routine_mean", | ||
| "cost_diagnostic_mean", | ||
| "cost_surveillance_mean", | ||
| "cost_treatment_initial_mean", | ||
| "cost_treatment_ongoing_mean", | ||
| "cost_treatment_terminal_mean", | ||
| "discounted_cost_routine_per_1k_40yo_mean", | ||
| "discounted_cost_diagnostic_per_1k_40yo_mean", | ||
| "discounted_cost_surveillance_per_1k_40yo_mean", | ||
| "discounted_cost_treatment_initial_per_1k_40yo_mean", | ||
| "discounted_cost_treatment_ongoing_per_1k_40yo_mean", | ||
| "discounted_cost_treatment_terminal_per_1k_40yo_mean", | ||
| "cost_routine_per_1k_40yo_mean", | ||
| "cost_diagnostic_per_1k_40yo_mean", | ||
| "cost_surveillance_per_1k_40yo_mean", | ||
| "cost_treatment_initial_per_1k_40yo_mean", | ||
| "cost_treatment_ongoing_per_1k_40yo_mean", | ||
| "cost_treatment_terminal_per_1k_40yo_mean", | ||
| "discounted_lifeobs_if_unscreened_undiagnosed_at_40_mean"] | ||
| summary_subset = summary[select_columns] |
There was a problem hiding this comment.
Was the additional analysis you were doing in excel just selecting a subset of columns? I thought there were some additional calculations involved.
Merge exp-consistent-lifespans and exp-consistent summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the summary script to create an extra sheet in the summarized.xlsx with select columns. We can use this for now, and add the columns as and when the requirements change.