Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken timezone issue and some linting #285

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix broken timezone issue and some linting #285

merged 1 commit into from
Dec 15, 2023

Conversation

AstridKery
Copy link
Contributor

This addresses two issues:

  1. The download labeled data was broken by one of the recent upgrades. The timezone normalizing was causing an error.
  2. A typo was discovered in the history table datetime rendering. %m was being used to render the minutes but %m is month and %M is minute.

@AstridKery AstridKery requested a review from rjruizes December 15, 2023 19:27
rjruizes
rjruizes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@rjruizes rjruizes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AstridKery AstridKery merged commit 6cc78e3 into dev Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjruizes rjruizes rjruizes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstridKery @rjruizes